danny0405 commented on a change in pull request #8966:
[FLINK-13074][table-planner-blink] Add PartitionableTableSink bridge logic to
flink&blink …
URL: https://github.com/apache/flink/pull/8966#discussion_r305356854
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/internal/BatchTableEnvImpl.scala
##########
@@ -133,6 +135,26 @@ abstract class BatchTableEnvImpl(
}
}
+ /**
+ * Key by the partition fields if the sink is a [[PartitionableTableSink]].
+ * @param sink the table sink
+ * @param dataSet the data set
+ * @tparam R the data set record type
+ * @return a data set that maybe keyed by.
+ */
+ private def mayKeyByPartitionFields[R](
Review comment:
Renamed to shuffleByPartitionFieldsIfNeeded.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
