danny0405 commented on a change in pull request #8966:
[FLINK-13074][table-planner-blink] Add PartitionableTableSink bridge logic to
flink&blink …
URL: https://github.com/apache/flink/pull/8966#discussion_r305353057
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/PlannerBase.scala
##########
@@ -173,7 +165,12 @@ abstract class PlannerBase(
case catalogSink: CatalogSinkModifyOperation =>
val input =
getRelBuilder.queryOperation(modifyOperation.getChild).build()
getTableSink(catalogSink.getTablePath).map(sink => {
- TableSinkUtils.validateSink(catalogSink.getChild,
catalogSink.getTablePath, sink)
+ TableSinkUtils.validateSink(catalogSink, catalogSink.getTablePath,
sink)
+ sink match {
+ case partitionableSink: PartitionableTableSink =>
Review comment:
The `PartitionableTableSink` is the only trait that `Flink` recognize as a
partiton sink, if the partitioned fields is empty, the static partitions are
always empty(we have checked this in sql node parse). So what exactly is the
unexpected effects ?
BTW, i don't think the two methods `#getPartitionFieldNames` and
`#setStaticPartition` should affect each other.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
