[ 
https://issues.apache.org/jira/browse/FLINK-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906439#comment-14906439
 ] 

ASF GitHub Bot commented on FLINK-2754:
---------------------------------------

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1177#issuecomment-142950553
  
    Looks good.
    
    This makes only sense to merge, if we move the MemorySegment micro 
benchmarks and the XORShift benchmarks to this module. @ChengXiangLi Would you 
be up for that part?
    
    Another question: Should the artifact of this project be deployed to maven 
central, or is this purely a project that people use when they work with the 
code? 


> FixedLengthRecordSorter can not write to output cross MemorySegments.
> ---------------------------------------------------------------------
>
>                 Key: FLINK-2754
>                 URL: https://issues.apache.org/jira/browse/FLINK-2754
>             Project: Flink
>          Issue Type: Bug
>          Components: Distributed Runtime
>            Reporter: Chengxiang Li
>            Assignee: Chengxiang Li
>
> FixedLengthRecordSorter can not write to output cross MemorySegments, it 
> works well as it's only called to write a single record before. Should fix it 
> and add more unit test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to