[ 
https://issues.apache.org/jira/browse/FLINK-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14907781#comment-14907781
 ] 

ASF GitHub Bot commented on FLINK-2754:
---------------------------------------

Github user chiwanpark commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1177#discussion_r40407595
  
    --- Diff: flink-benchmark/pom.xml ---
    @@ -0,0 +1,101 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one
    +or more contributor license agreements.  See the NOTICE file
    +distributed with this work for additional information
    +regarding copyright ownership.  The ASF licenses this file
    +to you under the Apache License, Version 2.0 (the
    +"License"); you may not use this file except in compliance
    +with the License.  You may obtain a copy of the License at
    +
    +  http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing,
    +software distributed under the License is distributed on an
    +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +KIND, either express or implied.  See the License for the
    +specific language governing permissions and limitations
    +under the License.
    +
    +-->
    +<project xmlns="http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
    +         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd";>
    +
    +  <modelVersion>4.0.0</modelVersion>
    +
    +  <parent>
    +    <groupId>org.apache.flink</groupId>
    +    <artifactId>flink-parent</artifactId>
    +    <version>0.10-SNAPSHOT</version>
    +    <relativePath>..</relativePath>
    +  </parent>
    +
    +  <artifactId>flink-benchmark</artifactId>
    +  <name>flink-benchmark</name>
    +  <packaging>jar</packaging>
    +
    +  <properties>
    +    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    +    <jmh.version>1.4.1</jmh.version>
    +    <uberjar.name>benchmarks</uberjar.name>
    +  </properties>
    +
    +  <dependencies>
    +    <dependency>
    +      <groupId>org.apache.flink</groupId>
    +      <artifactId>flink-clients</artifactId>
    +      <version>${project.version}</version>
    +    </dependency>
    +    <dependency>
    +      <groupId>org.openjdk.jmh</groupId>
    +      <artifactId>jmh-core</artifactId>
    +      <version>${jmh.version}</version>
    +    </dependency>
    +    <dependency>
    +      <groupId>org.openjdk.jmh</groupId>
    +      <artifactId>jmh-generator-annprocess</artifactId>
    +      <version>${jmh.version}</version>
    +      <scope>provided</scope>
    +    </dependency>
    +  </dependencies>
    +
    +  <build>
    +    <plugins>
    +      <plugin>
    +        <groupId>org.apache.maven.plugins</groupId>
    +        <artifactId>maven-shade-plugin</artifactId>
    +        <version>2.2</version>
    --- End diff --
    
    Could you remove this version tag? The version of `maven-shade-plugin` is 
controlled by parent POM.


> FixedLengthRecordSorter can not write to output cross MemorySegments.
> ---------------------------------------------------------------------
>
>                 Key: FLINK-2754
>                 URL: https://issues.apache.org/jira/browse/FLINK-2754
>             Project: Flink
>          Issue Type: Bug
>          Components: Distributed Runtime
>            Reporter: Chengxiang Li
>            Assignee: Chengxiang Li
>
> FixedLengthRecordSorter can not write to output cross MemorySegments, it 
> works well as it's only called to write a single record before. Should fix it 
> and add more unit test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to