Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1141#discussion_r40327817 --- Diff: flink-staging/flink-language-binding/flink-language-binding-generic/src/main/java/org/apache/flink/languagebinding/api/java/common/PlanBinder.java --- @@ -256,7 +258,20 @@ protected OperationInfo createOperationInfo(Operation operationIdentifier) throw protected abstract INFO createOperationInfo(AbstractOperation operationIdentifier) throws IOException; private void createCsvSource(OperationInfo info) throws IOException { - sets.put(info.setID, env.createInput(new CsvInputFormat(new Path(info.path), info.lineDelimiter, info.fieldDelimiter, info.types), info.types).name("CsvSource")); + if (!(info.types instanceof CompositeType)) { + throw new RuntimeException("The output type of a csv source has to be a tuple or a " + + "pojo type. The derived type is " + info); + } + + sets.put( --- End diff -- Style comment: I think that is a bit much line breaking for the common Java style. I think the common Java styles don't do that quite as heavy as the Scala style.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---