wuchong commented on issue #9203: [FLINK-13375][table-api] Move ExecutionConfigOptions and OptimizerConfigOptions to table-api URL: https://github.com/apache/flink/pull/9203#issuecomment-514220614 Hi @twalthr , @dawidwys , I have updated the pull request. I also update some option names according to the hierarchical naming convention and examples Timo pointed out. But I didn't adopt `.enabled` suffix changes, for example `table.exec.sort.async-merge.enabled` -> `table.exec.sort.async-merge-enabled`. I still keep it `table.exec.sort.async-merge.enabled`. Because `async-merge` is an individual word and may have sub-entries in the future, e.g. threads-num. The same to the other `enabled` options: `table.optimizer.reuse.sub-plan.enabled`, `table.optimizer.reuse.source.enabled`, `table.optimizer.predicate-pushdown.enabled`, `table.optimizer.join-reorder.enabled`. IMO, it will be more readable if separate `enabled` with the word before.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
