wuchong commented on issue #9203: [FLINK-13375][table-api] Move ExecutionConfigOptions and OptimizerConfigOptions to table-api URL: https://github.com/apache/flink/pull/9203#issuecomment-514235290 Thanks @twalthr for the detailed review. Regarding to the `.enabled` options, I left some thoughts above. I'm afraid we will have more sub-entries for those `.enabled` options. Take join-reorder as an example, spark has `spark.sql.cbo.joinReorder.enabled`, `spark.sql.cbo.joinReorder.dp.threshold`, `spark.sql.cbo.joinReorder.card.weight`. That's why I want to keep `.enabled`. And I think a hierarchy with one child can be valid as long as it is a reasonable word and may have sub-entries in the future. What do you think/
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
