[
https://issues.apache.org/jira/browse/FLINK-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14908131#comment-14908131
]
ASF GitHub Bot commented on FLINK-2576:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1138#discussion_r40440502
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/operators/base/JoinOperatorBase.java
---
@@ -47,99 +45,29 @@
/**
* @see org.apache.flink.api.common.functions.FlatJoinFunction
*/
-public class JoinOperatorBase<IN1, IN2, OUT, FT extends
FlatJoinFunction<IN1, IN2, OUT>> extends DualInputOperator<IN1, IN2, OUT, FT> {
-
- /**
- * An enumeration of hints, optionally usable to tell the system how
exactly execute the join.
- */
- public static enum JoinHint {
--- End diff --
Moving the `JoinHint` enum breaks the public API. Join hints are quite
often used and I would prefer to keep them at the same location.
What do you think about renaming *your* `AbstractJoinOperatorBase` class to
`JoinOperatorBase` and *your* `JoinOperatorBase` class to
`InnerJoinOperatorBase`?
Alternatively, we can also move the `JoinHint` enum from
`AbstractJoinOperatorBase` to `JoinOperatorBase`.
> Add outer joins to API and Optimizer
> ------------------------------------
>
> Key: FLINK-2576
> URL: https://issues.apache.org/jira/browse/FLINK-2576
> Project: Flink
> Issue Type: Sub-task
> Components: Java API, Optimizer, Scala API
> Reporter: Ricky Pogalz
> Priority: Minor
> Fix For: pre-apache
>
>
> Add left/right/full outer join methods to the DataSet APIs (Java, Scala) and
> to the optimizer of Flink.
> Initially, the execution strategy should be a sort-merge outer join
> (FLINK-2105) but can later be extended to hash joins for left/right outer
> joins.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
