twalthr commented on a change in pull request #9229:
[FLINK-13279][table-sql-client] Fully qualify sink name in sql-client
URL: https://github.com/apache/flink/pull/9229#discussion_r307756488
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/internal/TableEnvImpl.scala
##########
@@ -60,9 +60,9 @@ abstract class TableEnvImpl(
private val catalogManager: CatalogManager)
extends TableEnvironment {
- // The current catalog and database are definitely builtin.
- protected val builtinCatalogName: String = catalogManager.getCurrentCatalog
- protected val builtinDatabaseName: String = catalogManager.getCurrentDatabase
+ protected val builtInCatalogName: String =
catalogManager.getBuiltInCatalogName
Review comment:
nit: remove those variables and access catalog manager directly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
