twalthr commented on a change in pull request #9229:  
[FLINK-13279][table-sql-client] Fully qualify sink name in sql-client 
URL: https://github.com/apache/flink/pull/9229#discussion_r307765867
 
 

 ##########
 File path: 
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/LocalExecutorITCase.java
 ##########
 @@ -151,6 +155,44 @@ public void testValidateSession() throws Exception {
                assertEquals(expectedTables, actualTables);
        }
 
+       @Test(timeout = 30_000L)
+       public void testDefaultCatalogDifferentFromBuiltin() throws Exception {
+               Environment defaultEnvironment = new Environment();
+               Map<String, Object> catalogs = new HashMap<>();
+               catalogs.put(CatalogEntry.CATALOG_NAME, "simple-catalog");
 
 Review comment:
   add this to the yaml file instead?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to