xuefuz commented on a change in pull request #9264: [FLINK-13192][hive] Add
tests for different Hive table formats
URL: https://github.com/apache/flink/pull/9264#discussion_r308358835
##########
File path:
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/batch/connectors/hive/TableEnvHiveConnectorTest.java
##########
@@ -85,4 +87,40 @@ public void testDefaultPartitionName() throws Exception {
hiveShell.execute("drop database db1 cascade");
}
+
+ @Test
+ public void testDifferentFormats() throws Exception {
+ String[] formats = new String[]{"orc", "parquet",
"sequencefile"};
Review comment:
It would be great to cover text/csv as it's also comment, especially for
testing/poc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
