Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1127#discussion_r40535960
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/expressions/analysis/ResolveFieldReferences.scala
---
@@ -30,21 +33,43 @@ import org.apache.flink.api.table.trees.Rule
* Rule that resolved field references. This rule verifies that field
references point to existing
* fields of the input operation and creates [[ResolvedFieldReference]]s
that hold the field
* [[TypeInformation]] in addition to the field name.
+ *
+ * @param inputOperation is optional but required if resolved fields
should be pushed to underlying
+ * table sources.
+ * @param filtering defines if the field is resolved as a part of
filtering operation or not
*/
-class ResolveFieldReferences(inputFields: Seq[(String,
TypeInformation[_])])
+class ResolveFieldReferences(inputFields: Seq[(String,
TypeInformation[_])],
+ inputOperation: PlanNode,
+ filtering: Boolean)
--- End diff --
It is Scala Style to indent the parameters by 4 spaces (even the first
parameter) if they don't fit on a line, like so:
```scala
class ResolveFieldReferences(
inputFields: Seq[(String, TypeInformation[_])],
inputOperation: PlanNode,
filtering: Boolean) extends Rule[Expression] {
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
