[
https://issues.apache.org/jira/browse/FLINK-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933183#comment-14933183
]
ASF GitHub Bot commented on FLINK-2167:
---------------------------------------
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1127#issuecomment-143718074
Thanks @aljoscha for reviewing my code! Sorry for the bad Scala style. This
was my first really large Scala code project I wrote (not just small scripts),
I'm still learning by doing ;) I will correct the issues you mentioned.
For the technical part: Yes, I don't modify the expression tree, I'm just
giving the sources the possibility to adapt to the need of the program.
Regarding the `supports*` methods, yes you are right, actually they are not
necessary, but I thought it makes sense for possible future table sources to
check that in advance. In some cases it also reduces the amout of some method
calls, but I can also remove the `supports*` methods for reason of simplicity,
no problem.
> Add fromHCat() to TableEnvironment
> ----------------------------------
>
> Key: FLINK-2167
> URL: https://issues.apache.org/jira/browse/FLINK-2167
> Project: Flink
> Issue Type: New Feature
> Components: Table API
> Affects Versions: 0.9
> Reporter: Fabian Hueske
> Assignee: Timo Walther
> Priority: Minor
> Labels: starter
>
> Add a {{fromHCat()}} method to the {{TableEnvironment}} to read a {{Table}}
> from an HCatalog table.
> The implementation could reuse Flink's HCatInputFormat.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
