[
https://issues.apache.org/jira/browse/FLINK-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933109#comment-14933109
]
ASF GitHub Bot commented on FLINK-2167:
---------------------------------------
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1127#discussion_r40535960
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/expressions/analysis/ResolveFieldReferences.scala
---
@@ -30,21 +33,43 @@ import org.apache.flink.api.table.trees.Rule
* Rule that resolved field references. This rule verifies that field
references point to existing
* fields of the input operation and creates [[ResolvedFieldReference]]s
that hold the field
* [[TypeInformation]] in addition to the field name.
+ *
+ * @param inputOperation is optional but required if resolved fields
should be pushed to underlying
+ * table sources.
+ * @param filtering defines if the field is resolved as a part of
filtering operation or not
*/
-class ResolveFieldReferences(inputFields: Seq[(String,
TypeInformation[_])])
+class ResolveFieldReferences(inputFields: Seq[(String,
TypeInformation[_])],
+ inputOperation: PlanNode,
+ filtering: Boolean)
--- End diff --
It is Scala Style to indent the parameters by 4 spaces (even the first
parameter) if they don't fit on a line, like so:
```scala
class ResolveFieldReferences(
inputFields: Seq[(String, TypeInformation[_])],
inputOperation: PlanNode,
filtering: Boolean) extends Rule[Expression] {
```
> Add fromHCat() to TableEnvironment
> ----------------------------------
>
> Key: FLINK-2167
> URL: https://issues.apache.org/jira/browse/FLINK-2167
> Project: Flink
> Issue Type: New Feature
> Components: Table API
> Affects Versions: 0.9
> Reporter: Fabian Hueske
> Assignee: Timo Walther
> Priority: Minor
> Labels: starter
>
> Add a {{fromHCat()}} method to the {{TableEnvironment}} to read a {{Table}}
> from an HCatalog table.
> The implementation could reuse Flink's HCatInputFormat.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
