twalthr commented on a change in pull request #9275:
[FLINK-13290][table-planner-blink][hbase] SinkCodeGenerator should not compare
row type field names and enable blink planner for hbase IT case
URL: https://github.com/apache/flink/pull/9275#discussion_r309218217
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/utils/LogicalTypeChecks.java
##########
@@ -145,6 +156,14 @@ public static boolean isSingleFieldInterval(LogicalType
logicalType) {
return logicalType.accept(SINGLE_FIELD_INTERVAL_EXTRACTOR);
}
+ public static boolean areTypeEqualsWithoutNames(LogicalType thisType,
LogicalType thatType) {
+ if (thisType == null || thatType == null) {
Review comment:
It's better to add a precondition here. Types should not be null. If they
are null, it is a bug that should throw an exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
