twalthr commented on a change in pull request #9275:
[FLINK-13290][table-planner-blink][hbase] SinkCodeGenerator should not compare
row type field names and enable blink planner for hbase IT case
URL: https://github.com/apache/flink/pull/9275#discussion_r309218353
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/utils/LogicalTypeChecks.java
##########
@@ -332,4 +351,162 @@ public Boolean visit(DayTimeIntervalType
dayTimeIntervalType) {
}
}
}
+
+ private static class TypeEquivalenceIgnoreNamesExtractor extends
Extractor<Boolean> {
Review comment:
Should directly extend from `LogicalTypeDefaultVisitor` because we override
the default method anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services