wuchong commented on a change in pull request #9277: 
[FLINK-13494][table-planner-blink] Only use env parallelism for sql job
URL: https://github.com/apache/flink/pull/9277#discussion_r309233023
 
 

 ##########
 File path: 
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java
 ##########
 @@ -83,18 +83,8 @@
        public static final ConfigOption<Integer> 
TABLE_EXEC_RESOURCE_DEFAULT_PARALLELISM =
                key("table.exec.resource.default-parallelism")
                        .defaultValue(-1)
-                       .withDescription("Default parallelism of job operators. 
If it is <= 0, use parallelism of StreamExecutionEnvironment(" +
-                               "its default value is the num of cpu cores in 
the client host).");
-
-       public static final ConfigOption<Integer> 
TABLE_EXEC_RESOURCE_SOURCE_PARALLELISM =
-               key("table.exec.resource.source.parallelism")
-                       .defaultValue(-1)
-                       .withDescription("Sets source parallelism, if it is <= 
0, use " + TABLE_EXEC_RESOURCE_DEFAULT_PARALLELISM.key() + " to set source 
parallelism.");
-
-       public static final ConfigOption<Integer> 
TABLE_EXEC_RESOURCE_SINK_PARALLELISM =
-               key("table.exec.resource.sink.parallelism")
-                       .defaultValue(-1)
-                       .withDescription("Sets sink parallelism, if it is <= 0, 
use " + TABLE_EXEC_RESOURCE_DEFAULT_PARALLELISM.key() + " to set sink 
parallelism.");
+                       .withDescription("Default parallelism to override 
parallelism of " +
+                                       "StreamExecutionEnvironment. If it is 
<= 0, not to override.");
 
 Review comment:
   Sets default parallelism of x for all operators (such as aggregate, join, 
filter)  to run with x parallel instances. This config has a higher priority 
than parallelism of StreamExecutionEnvironment (actually, this config overrides 
the parallelism of StreamExecutionEnvironment). A value of -1 indicates that no 
default parallelism is set, then it will fallback to use the parallelism of 
StreamExecutionEnvironment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to