wuchong commented on a change in pull request #9277:
[FLINK-13494][table-planner-blink] Only use env parallelism for sql job
URL: https://github.com/apache/flink/pull/9277#discussion_r309964072
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamExecSink.scala
##########
@@ -145,12 +145,12 @@ class StreamExecSink[T](
"implemented and return the sink transformation DataStreamSink. " +
s"However, ${sink.getClass.getCanonicalName} doesn't implement
this method.")
}
- if (!UpdatingPlanChecker.isAppendOnly(this) &&
- dsSink.getTransformation.getParallelism !=
transformation.getParallelism) {
- throw new TableException(s"The configured sink parallelism should be
equal to the" +
+ if (!UpdatingPlanChecker.isAppendOnly(this) &&
dsSink.getTransformation.getParallelism != 1
+ && dsSink.getTransformation.getParallelism !=
transformation.getParallelism) {
Review comment:
Is there a possible `transformation.getParallelism` is -1, however,
`dsSink.getTransformation.getParallelism` is env.getParallelism which is 4? In
this case, they can be chained, but an exception will be thrown.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
