danny0405 commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#discussion_r309231304
########## File path: flink-table/flink-sql-parser/src/main/codegen/data/Parser.tdd ########## @@ -384,13 +392,24 @@ literalParserMethods: [ ] - # List of methods for parsing custom data types. + # List of methods for parsing flink custom data types. # Return type of method implementation should be "SqlIdentifier". # Example: SqlParseTimeStampZ(). - dataTypeParserMethods: [ + flinkDataTypeParserMethods: [ Review comment: Agree for this line but not for the other parser block, because we actually use the Calcite core parser, use Flink keyword to distinguish the same function parse logic seems reasonable to me. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
