danny0405 commented on a change in pull request #9243:
[FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37
URL: https://github.com/apache/flink/pull/9243#discussion_r309959336
##########
File path:
flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl
##########
@@ -367,53 +375,299 @@ SqlDrop SqlDropView(Span s, boolean replace) :
}
}
+SqlIdentifier FlinkCollectionsTypeName() :
+{
+}
+{
+ LOOKAHEAD(2)
+ <MULTISET> {
+ return new SqlIdentifier(SqlTypeName.MULTISET.name(), getPos());
+ }
+|
+ <ARRAY> {
+ return new SqlIdentifier(SqlTypeName.ARRAY.name(), getPos());
+ }
+}
+
+SqlIdentifier FlinkTypeName() :
+{
+ final SqlTypeName sqlTypeName;
+ final SqlIdentifier typeName;
+ final Span s = Span.of();
+}
+{
+ (
+<#-- additional types are included here -->
+<#-- make custom data types in front of Calcite core data types -->
+<#list parser.flinkDataTypeParserMethods as method>
+ <#if (method?index > 0)>
+ |
+ </#if>
+ LOOKAHEAD(2)
+ typeName = ${method}
+</#list>
+ |
+ LOOKAHEAD(2)
+ sqlTypeName = SqlTypeName(s) {
+ typeName = new SqlIdentifier(sqlTypeName.name(), s.end(this));
+ }
+ |
+ LOOKAHEAD(2)
+ typeName = FlinkCollectionsTypeName()
+ |
+ typeName = CompoundIdentifier() {
+ throw new ParseException("UDT in DDL is not supported yet.");
Review comment:
Yes. Let's postpone full type support for cast for 1.10, when i finished the
data type parse refactoring in Calcite[1], which would be into release 1.21.
BTW, the full implicit type cast[2] support would be into release 1.21 too.
[1] https://issues.apache.org/jira/browse/CALCITE-3213
[2] https://issues.apache.org/jira/browse/CALCITE-2302
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
