wuchong commented on a change in pull request #9099:
[FLINK-13237][table-planner-blink] Add expression table api test to blink
URL: https://github.com/apache/flink/pull/9099#discussion_r309538399
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/utils/ExpressionTestBase.scala
##########
@@ -162,31 +169,34 @@ abstract class ExpressionTestBase {
}
assertEquals(
- s"Wrong result for: [$originalExpr] optimized to:
[$optimizedExpr]",
+ s"Wrong result for: [$optimizedExpr]",
expected,
if (actual == null) "null" else actual)
}
}
- private def addSqlTestExpr(sqlExpr: String, expected: String): Unit = {
+ def addSqlTestExpr(sqlExpr: String, expected: String): Unit = {
Review comment:
This method should be `private`. The only test which call this method can be
removed because we don't support implicit type conversion yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
