wuchong commented on a change in pull request #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink URL: https://github.com/apache/flink/pull/9099#discussion_r309564946
########## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/UserDefinedScalarFunctionTest.scala ########## @@ -0,0 +1,468 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.planner.expressions + +import org.apache.flink.api.common.typeinfo.{BasicArrayTypeInfo, TypeInformation} +import org.apache.flink.api.java.typeutils.RowTypeInfo +import org.apache.flink.table.api.scala._ +import org.apache.flink.table.api.{DataTypes, Types, ValidationException} +import org.apache.flink.table.functions.ScalarFunction +import org.apache.flink.table.planner.expressions.utils.{ExpressionTestBase, _} +import org.apache.flink.table.planner.runtime.utils.JavaUserDefinedScalarFunctions._ +import org.apache.flink.table.planner.utils.DateTimeTestUtil +import org.apache.flink.types.Row + +import org.junit.Test + +import java.lang.{Boolean => JBoolean} + +class UserDefinedScalarFunctionTest extends ExpressionTestBase { + + @Test + def testParameters(): Unit = { + testAllApis( + Func0('f0), + "Func0(f0)", + "Func0(f0)", + "42") + + testAllApis( + Func1('f0), + "Func1(f0)", + "Func1(f0)", + "43") + + testAllApis( + Func1('f11), + "Func1(f11)", + "Func1(f11)", + "4") + + testAllApis( + Func1('f12), + "Func1(f12)", + "Func1(f12)", + "4") + + testAllApis( + Func1('f13), + "Func1(f13)", + "Func1(f13)", + "4.0") + + testAllApis( + Func2('f0, 'f1, 'f3), + "Func2(f0, f1, f3)", + "Func2(f0, f1, f3)", + "42 and Test and SimplePojo(Bob,36)") + + testAllApis( + Func0(123), + "Func0(123)", + "Func0(123)", + "123") + + // TODO: GenericType with Date/Time/Timestamp -> String would call toString implicitl + testAllApis( + Func6('f4, 'f5, 'f6), + "Func6(f4, f5, f6)", + "Func6(f4, f5, f6)", + "(1990-10-14,12:10:10,1990-10-14 12:10:10.0)") + + // function names containing keywords + testAllApis( + Func0('f0), + "getFunc0(f0)", + "getFunc0(f0)", + "42") + + testAllApis( + Func0('f0), + "asAlways(f0)", + "asAlways(f0)", + "42") + + testAllApis( + Func0('f0), + "toWhatever(f0)", + "toWhatever(f0)", + "42") + + testAllApis( + Func0('f0), + "Nullable(f0)", + "Nullable(f0)", + "42") + + // test row type input + testAllApis( + Func20('f14), + "Func20(f14)", + "Func20(f14)", + "(12,true,(1,2,3))" + ) + } + + @Test + def testNullableParameters(): Unit = { + testAllApis( + Func3(nullOf(DataTypes.INT), nullOf(DataTypes.STRING)), + "Func3(Null(INT), Null(STRING))", + "Func3(NULL, NULL)", + "null and null") + + testAllApis( + Func3(nullOf(DataTypes.INT), "Test"), + "Func3(Null(INT), 'Test')", + "Func3(NULL, 'Test')", + "null and Test") + + testAllApis( + Func3(42, nullOf(DataTypes.STRING)), + "Func3(42, Null(STRING))", + "Func3(42, NULL)", + "42 and null") + + testAllApis( + Func0(nullOf(DataTypes.INT)), + "Func0(Null(INT))", + "Func0(NULL)", + "-1") + } + + @Test + def testDoubleQuoteParameters(): Unit = { + val hello = "\"<hello>\"" + testAllApis( + Func3(42, hello), + s"Func3(42, '$hello')", + s"Func3(42, '$hello')", + s"42 and $hello") + } + + @Test + def testResults(): Unit = { + testAllApis( + Func4(), + "Func4()", + "Func4()", + "null") + + testAllApis( + Func5(), + "Func5()", + "Func5()", + "-1") + } + + @Test + def testNesting(): Unit = { + testAllApis( + Func0(Func0('f0)), + "Func0(Func0(f0))", + "Func0(Func0(f0))", + "42") + + testAllApis( + Func0(Func0('f0)), + "Func0(Func0(f0))", + "Func0(Func0(f0))", + "42") + + testAllApis( + Func7(Func7(Func7(1, 1), Func7(1, 1)), Func7(Func7(1, 1), Func7(1, 1))), + "Func7(Func7(Func7(1, 1), Func7(1, 1)), Func7(Func7(1, 1), Func7(1, 1)))", + "Func7(Func7(Func7(1, 1), Func7(1, 1)), Func7(Func7(1, 1), Func7(1, 1)))", + "8") + } + + @Test + def testOverloadedParameters(): Unit = { + testAllApis( + Func8(1), + "Func8(1)", + "Func8(1)", + "a") + + testAllApis( + Func8(1, 1), + "Func8(1, 1)", + "Func8(1, 1)", + "b") + + testAllApis( + Func8("a", "a"), + "Func8('a', 'a')", + "Func8('a', 'a')", + "c") Review comment: Add some missing tests: ```scala testAllApis( Func21('f15), "Func21(f15)", "Func21(f15)", "student#Bob") testAllApis( Func22('f16), "Func22(f16)", "Func22(f16)", "student#Bob") ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
