wuchong commented on a change in pull request #9099:
[FLINK-13237][table-planner-blink] Add expression table api test to blink
URL: https://github.com/apache/flink/pull/9099#discussion_r309590101
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/ScalarFunctionsTest.scala
##########
@@ -3178,4 +4161,10 @@ class ScalarFunctionsTest extends ScalarTypesTestBase {
"2")
}
+ @Ignore // Implicit type conversion
+ @Test
+ def testEmptyStringToTime(): Unit = {
Review comment:
Remove this test if we don't support implicit type conversion yet?
I think we need to add a bunch of thorough tests when supporting implicit
type conversion instead of enable the ignored tests. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
