GJL commented on issue #9271: [FLINK-13384][1.9][runtime] Fix back pressure sampling for SourceStreamTask URL: https://github.com/apache/flink/pull/9271#issuecomment-517350857 Imo using ``` Thread.currentThread().setContextClassLoader(userCodeClassLoader) ``` doesn't make the code more maintainable. Moreover, tests that currently call `Task#run()` directly can only break if we introduce this change (also note that we do not unset the context class loader). FLINK-13384 is a bug ticket, and I'd refrain from changing more behavior unless absolutely necessary. If a code restructuring/refactoring is needed, we can do it in a separate ticket.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
