Myasuka commented on a change in pull request #9268: [FLINK-13452] Ensure to
fail global when exception happens during reseting tasks of regions
URL: https://github.com/apache/flink/pull/9268#discussion_r309962573
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/AdaptedRestartPipelinedRegionStrategyNGFailoverTest.java
##########
@@ -376,12 +410,13 @@ private JobGraph createBatchJobGraph() {
}
private ExecutionGraph createExecutionGraph(final JobGraph jobGraph)
throws Exception {
- return createExecutionGraph(jobGraph, new
FixedDelayRestartStrategy(10, 0));
+ return createExecutionGraph(jobGraph, new
FixedDelayRestartStrategy(10, 0), false);
}
private ExecutionGraph createExecutionGraph(
final JobGraph jobGraph,
- final RestartStrategy restartStrategy) throws Exception
{
+ final RestartStrategy restartStrategy,
+ final boolean failOnRecoverCheckpoint) throws Exception
{
Review comment:
Agreed, combine `testFailGlobalIfErrorOnResetTasks` and previous
`testFailGlobalIfErrorOnRescheduleTasks` into one unit test as
`testFailGlobalIfErrorOnRestartTasks` with given RestartStrategy which would
fail when restarting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
