Myasuka commented on a change in pull request #9268: [FLINK-13452] Ensure to
fail global when exception happens during reseting tasks of regions
URL: https://github.com/apache/flink/pull/9268#discussion_r309969704
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/RegionFailoverITCase.java
##########
@@ -97,8 +111,10 @@
@Before
public void setup() throws Exception {
+ HighAvailabilityServicesUtilsTest.TestHAFactory.haServices =
new FailHaServices(new TestingCheckpointRecoveryFactory(new
FailRecoverCompletedCheckpointStore(1, 1), new
StandaloneCheckpointIDCounter()), TestingUtils.defaultExecutor());
Configuration configuration = new Configuration();
configuration.setString(JobManagerOptions.EXECUTION_FAILOVER_STRATEGY,
"region");
+ configuration.setString(HighAvailabilityOptions.HA_MODE,
HighAvailabilityServicesUtilsTest.TestHAFactory.class.getName());
Review comment:
Previously, the `RegionFailoverITCase` did not catch bug of
[FLINK-13452](https://issues.apache.org/jira/browse/FLINK-13452) due to it did
not involve global failover but only region failover. I prefer to add global
failover in this integration test to verify the job could be restarted and
result still correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
