dawidwys commented on a change in pull request #9313: [FLINK-13504][table]
Fixed shading issues in table modules.
URL: https://github.com/apache/flink/pull/9313#discussion_r310021501
##########
File path: flink-table/flink-table-uber/pom.xml
##########
@@ -96,8 +95,8 @@ under the License.
<configuration>
<artifactSet>
<includes
combine.children="append">
+ <!--Sql
parser is included in planners-->
Review comment:
It does. We do not relocate any packages in the `table-uber` jar. The
sql-parser is relocated and included in the uber jar of `table-planner*`
modules. This is not the case for the api modules. Planners just declare
dependency on those, but they do not bundle them into the jars
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
