dawidwys commented on a change in pull request #9313: [FLINK-13504][table] Fixed shading issues in table modules. URL: https://github.com/apache/flink/pull/9313#discussion_r310022047
########## File path: flink-end-to-end-tests/run-pre-commit-tests.sh ########## @@ -60,6 +60,7 @@ run_test "Modern Kafka end-to-end test" "$END_TO_END_DIR/test-scripts/test_strea run_test "Kinesis end-to-end test" "$END_TO_END_DIR/test-scripts/test_streaming_kinesis.sh" run_test "class loading end-to-end test" "$END_TO_END_DIR/test-scripts/test_streaming_classloader.sh" run_test "Distributed cache end-to-end test" "$END_TO_END_DIR/test-scripts/test_streaming_distributed_cache_via_blob.sh" +run_test "Dependency shading of table module test" "$END_TO_END_DIR/test-scripts/test_table_shaded_dependencies.sh" Review comment: Do you mean you wouldn't add this test to pre commit tests? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
