sunjincheng121 commented on a change in pull request #9322: 
[FLINK-13471][table] Add FlatAggregate support to stream Table API(blink 
planner)
URL: https://github.com/apache/flink/pull/9322#discussion_r310175806
 
 

 ##########
 File path: 
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/agg/AggsHandlerCodeGenerator.scala
 ##########
 @@ -700,14 +841,21 @@ class AggsHandlerCodeGenerator(
     """.stripMargin
   }
 
+  private def genEmitValue(): String = {
 
 Review comment:
   This method would also be used for the window flatAggregate, i.e., would 
also be used in generateWindowTableAggsHandler() later.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to