wuchong commented on a change in pull request #9285:
[FLINK-13433][table-planner-blink] Do not fetch data from
LookupableTableSource if the JoinKey in left side of LookupJoin contains null
value.
URL: https://github.com/apache/flink/pull/9285#discussion_r310390595
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/LookupJoinCodeGenerator.scala
##########
@@ -87,11 +87,16 @@ object LookupJoinCodeGenerator {
s"$lookupFunctionTerm.setCollector($DEFAULT_COLLECTOR_TERM);"
}
+ // TODO assume filterNulls are all true here
Review comment:
This comment is still hard to understand. I can't find `filterNulls` in the
context.
Suggestion:
```
TODO: filter all records when we meet any nulls on the join key, because we
don't support "IS NOT DISTINCT FROM" currently.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
