wuchong commented on a change in pull request #9285:
[FLINK-13433][table-planner-blink] Do not fetch data from
LookupableTableSource if the JoinKey in left side of LookupJoin contains null
value.
URL: https://github.com/apache/flink/pull/9285#discussion_r310390327
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/LookupJoinCodeGenerator.scala
##########
@@ -197,7 +208,11 @@ object LookupJoinCodeGenerator {
""".stripMargin
(code, newTerm)
Review comment:
We can return nullterm here `(code, newTerm, e.nullTerm)`, and then the
`nullInParameters` can be simplified to `codeAndArg.map(_._3).mkString("||")`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
