kl0u commented on a change in pull request #9321: [FLINK-13486][tests] Optimize
AsyncDataStreamITCase to alleviate the …
URL: https://github.com/apache/flink/pull/9321#discussion_r310532941
##########
File path:
flink-streaming-scala/src/test/scala/org/apache/flink/streaming/api/scala/AsyncDataStreamITCase.scala
##########
@@ -88,31 +89,16 @@ class AsyncDataStreamITCase extends AbstractTestBase {
}
@Test
- def testOrderedWaitUsingAnonymousFunction(): Unit = {
- testAsyncWaitUsingAnonymousFunction(true)
- }
-
- @Test
- def testUnorderedWaitUsingAnonymousFunction(): Unit = {
- testAsyncWaitUsingAnonymousFunction(false)
+ def testOrderedWait(): Unit = {
Review comment:
Please revert all the renamings to their previous names
(`testOrderedWaitUsingAnonymousFunction`,
`testUnorderedWaitUsingAnonymousFunction`, and
`testAsyncWaitUsingAnonymousFunction`), as refactorings should not be part of
this PR (they are not relevant to the attached JIRA issue) and also I think
that, although not perfect, the previous names were giving more information
about what the tests are trying to do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
