kl0u commented on a change in pull request #9321: [FLINK-13486][tests] Optimize AsyncDataStreamITCase to alleviate the … URL: https://github.com/apache/flink/pull/9321#discussion_r310531724
########## File path: flink-streaming-scala/src/test/scala/org/apache/flink/streaming/api/scala/AsyncDataStreamITCase.scala ########## @@ -33,37 +32,39 @@ import scala.collection.mutable import scala.concurrent.{ExecutionContext, Future} object AsyncDataStreamITCase { - val timeout = 1000L + val timeout = 10000L Review comment: These two variables can become local variables in the private methods (`testAsyncWaitTimeout` and `testAsyncWaitUsingAnonymousFunction`) that execute the tests. This will help the readability of the tests as the reader will not have to scroll up and down to see the values. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services