wuchong commented on a change in pull request #9335: [FLINK-13503][API] Add
contract in `LookupableTableSource` to specify the behavior when lookupKeys
contains null.
URL: https://github.com/apache/flink/pull/9335#discussion_r311845514
##########
File path:
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCLookupFunction.java
##########
@@ -76,7 +87,8 @@
private final int maxRetryTimes;
private transient Connection dbConn;
- private transient PreparedStatement statement;
+ private transient PreparedStatement fastStatement;
+ private transient PreparedStatement slowStatement;
Review comment:
If we have a consensus on the new methods of `SqlDialect`. We can rename
these fields to `nullSafeStatemen` and `nullUnsafeStatement`, we can add
comment on the fields that we should use `nullUnsafeStatement` as much as
possible because it is faster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
