wuchong commented on a change in pull request #9335: [FLINK-13503][API] Add
contract in `LookupableTableSource` to specify the behavior when lookupKeys
contains null.
URL: https://github.com/apache/flink/pull/9335#discussion_r310451676
##########
File path:
flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseLookupFunction.java
##########
@@ -72,7 +75,15 @@ public HBaseLookupFunction(
*/
public void eval(Object rowKey) throws IOException {
// fetch result
- Result result = table.get(readHelper.createGet(rowKey));
+ byte[] row = readHelper.serialize(rowKey);
+ Get get;
+ try {
+ get = readHelper.createGet(row);
+ } catch (IllegalArgumentException e) {
Review comment:
We shouldn't use try catch to do this job in performance critical code. We
can return if length of `row` is zero.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
