tillrohrmann commented on a change in pull request #9106: [FLINK-13184][yarn]
Support launching task executors with multi-thread on YARN.
URL: https://github.com/apache/flink/pull/9106#discussion_r313569650
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
##########
@@ -574,4 +609,9 @@ private ContainerLaunchContext
createTaskExecutorLaunchContext(Resource resource
.put(ENV_FLINK_NODE_ID, host);
return taskExecutorLaunchContext;
}
+
+ @VisibleForTesting
+ Executor getStartContainerExecutor() {
+ return startContainerExecutor;
+ }
Review comment:
This looks like a code smell. If we pass in the `ExecutorService`, then
there should be no need for a `@VisibleForTesting` method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
