tillrohrmann commented on a change in pull request #9106: [FLINK-13184][yarn] 
Support launching task executors with multi-thread on YARN.
URL: https://github.com/apache/flink/pull/9106#discussion_r313797439
 
 

 ##########
 File path: 
flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java
 ##########
 @@ -188,6 +188,14 @@
                .defaultValue("")
                .withDescription("A comma-separated list of tags to apply to 
the Flink YARN application.");
 
+       /**
+        * The max number of threads for starting yarn containers in yarn 
resource manager.
+        */
+       public static final ConfigOption<Integer> CONTAINER_LAUNCHER_NUM_MAX =
 
 Review comment:
   Hmm ok, I think the problem arises because we are using the `NMClient` 
instead of the `NMClientAsync`. Hence the `startContainer` waits for the 
completion. Wouldn't using the `NMClientAsync` be the much better solution 
instead of introducing a new `ExecutorService` which makes the `NMClient` 
asynchronous?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to