azagrebin commented on a change in pull request #9258: [FLINK-13460][tests]
Rework SerializedThrowableTest to not use Unsafe#defineClass()
URL: https://github.com/apache/flink/pull/9258#discussion_r313927314
##########
File path:
flink-test-utils-parent/flink-test-utils-junit/src/test/java/org/apache/flink/core/testutils/CommonTestUtilsTest.java
##########
@@ -45,7 +47,29 @@ public void testObjectFromNewClassLoaderObject() throws
Exception {
@Test
public void testObjectFromNewClassLoaderClassLoaders() throws Exception
{
- final CommonTestUtils.ObjectAndClassLoader objectAndClassLoader
= CommonTestUtils.createObjectFromNewClassLoader();
+ final CommonTestUtils.ObjectAndClassLoader<Serializable>
objectAndClassLoader =
CommonTestUtils.createSerializableObjectFromNewClassLoader();
Review comment:
maybe factor out one common helper test method where it does not matter
whether it is `Serializable` or `Exception`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
