azagrebin commented on a change in pull request #9258: [FLINK-13460][tests]
Rework SerializedThrowableTest to not use Unsafe#defineClass()
URL: https://github.com/apache/flink/pull/9258#discussion_r314246617
##########
File path:
flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/core/testutils/CommonTestUtils.java
##########
@@ -159,14 +159,14 @@ public static void setEnv(Map<String, String> newenv,
boolean clearExisting) {
/**
* A new object and the corresponding ClassLoader for that object, as
returned by
- * {@link #createObjectFromNewClassLoader(ClassLoader)}.
+ * {@link #createSerializableObjectFromNewClassLoader(ClassLoader)}.
Review comment:
I did not mean this particular method name
`createSerializableObjectFromNewClassLoader`.
`ObjectAndClassLoader` is also returned by the exception version of
`createObjectFromNewClassLoader`.
Ok, it is nit anyways: could add `as E.G. as returned by`
If `Serializab`ility is important, it could be also bounded type parameter:
`T extends Serializable`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
