1u0 commented on a change in pull request #9383: [FLINK-13248] [runtime] Adding 
processing of downstream messages in AsyncWaitOperator's wait loops
URL: https://github.com/apache/flink/pull/9383#discussion_r314286078
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/TaskMailboxImpl.java
 ##########
 @@ -251,4 +280,79 @@ public void quiesce() {
        public State getState() {
                return state;
        }
+
+       @Override
+       public Mailbox getDownstreamMailbox(AbstractStreamOperator<?> operator) 
{
+               return 
getDownstreamMailbox(operator.getOperatorConfig().getChainIndex());
 
 Review comment:
   Suggestion: implementation wise, only the 
`AbstractStreamOperator<?>.getOperatorConfig().getChainIndex()` is used here.
   
   You can decouple `TaskMailboxImpl` from `AbstractStreamOperator` at all, so 
the method becomes `Mailbox getDownstreamMailbox(int priority)`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to