1u0 commented on a change in pull request #9383: [FLINK-13248] [runtime] Adding
processing of downstream messages in AsyncWaitOperator's wait loops
URL: https://github.com/apache/flink/pull/9383#discussion_r315126159
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractStreamOperator.java
##########
@@ -227,11 +233,73 @@ public void setup(StreamTask<?, ?> containingTask,
StreamConfig config, Output<S
}
this.runtimeContext = new StreamingRuntimeContext(this,
environment, container.getAccumulatorMap());
+ this.mailboxExecutor =
this.getContainingTask().getMailboxExecutor(config.getChainIndex());
stateKeySelector1 = config.getStatePartitioner(0,
getUserCodeClassloader());
stateKeySelector2 = config.getStatePartitioner(1,
getUserCodeClassloader());
}
+ /**
+ * Allows downstream operators in the operator chain to process events.
+ * <p>This method should be called whenever an operator would need to
block the task thread to wait for output
Review comment:
Suggestion: use new (empty) line before `<p>` and remove the closing
`</p>`s. This "convention" is more common in the Flink codebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
