Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41024851
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
@@ -110,61 +120,68 @@
public CheckpointCoordinator(
JobID job,
- int numSuccessfulCheckpointsToRetain,
long checkpointTimeout,
ExecutionVertex[] tasksToTrigger,
ExecutionVertex[] tasksToWaitFor,
ExecutionVertex[] tasksToCommitTo,
- ClassLoader userClassLoader) {
+ ClassLoader userClassLoader,
+ CheckpointIDCounter checkpointIDCounter,
+ CompletedCheckpoints completedCheckpoints,
+ RecoveryMode recoveryMode) throws Exception {
// some sanity checks
if (job == null || tasksToTrigger == null ||
tasksToWaitFor == null || tasksToCommitTo ==
null) {
throw new NullPointerException();
}
- if (numSuccessfulCheckpointsToRetain < 1) {
- throw new IllegalArgumentException("Must retain at
least one successful checkpoint");
- }
if (checkpointTimeout < 1) {
throw new IllegalArgumentException("Checkpoint timeout
must be larger than zero");
}
this.job = job;
--- End diff --
Maybe we could harmonize the null checking as you've done it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
