TisonKun opened a new pull request #9509: [FLINK-13750][client] Separate client/cluster-side high-availability services URL: https://github.com/apache/flink/pull/9509 ## What is the purpose of the change Follow FLINK-13750 we decide to separate client-side/cluster-side high-availability services, in order to avoid issues like FLINK-13500 which initialized blob store service without auth. **NOTE:** This pull request is functionality completed but still a rough attempt to solve the problem. There is no tricky code in production scope(I hope so) but could be optimized in code style, local strategy, document and so on. I publish it here for early review and make sure we go on the right way. cc @tillrohrmann @zentol ## Brief change log + Introduce a new interface `ClientHaServices` and its implementations `StandaloneClientHaService` and `ZKClientHaService`. This interface include only one method, `getWebMonitorLeaderRetriever`, since client is only supposed to communicate with WebMonitor. + Add a method `createClientHaService` to `HighAvailabilityServicesFactory` for customized. By default it reuses `createHAServices` and `getWebMonitorLeaderRetriever`. The default behavior is for backward compatibility. + Add a method `createClientHaService` to `HighAvailabilityServicesUtils`. + Support "/leader-info" request on WebMonitor for a proper `LeaderConnectionInfo` query. (`LeaderInfo`, `LeaderInfoHandler`, and `LeaderInfoHeaders`) + Remove unused constructor in `RestClusterClient` and `ClusterClient`. + Adjust existing code. + Add a new tests `RetrieveLeaderInfoTest`. ## Verifying this change This change added tests and can be verified as follows: + `org.apache.flink.client.RetrieveLeaderInfoTest` to test `getClusterConnectionInfo` dedicatedly. + other functions should be covered by existing tests. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (don't know, we introduce client ha service but actually it has nothing to do with recovery) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
