zentol commented on a change in pull request #9512: [FLINK-13819][coordination] 
Introduce State for RpcEndpoint
URL: https://github.com/apache/flink/pull/9512#discussion_r316666391
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/RpcEndpoint.java
 ##########
 @@ -323,6 +355,15 @@ public void validateRunsInMainThread() {
                assert 
MainThreadValidatorUtil.isRunningInExpectedThread(currentMainThread.get());
        }
 
+       /**
+        * Rpc endpoint's state.
+        */
+       public enum State {
+               CREATED,
+               STARTED,
+               STOPPING
 
 Review comment:
   What's the reasoning for `STOPPING`, set at the beginning of the stop 
operation, opposed to `STOPPED`, set after the stop operation?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to