[
https://issues.apache.org/jira/browse/FLINK-13762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhijiang updated FLINK-13762:
-----------------------------
Description:
Currently StreamOneInputProcessor and StreamTwoInputSelectableProcessor have
separate implementations of ForwardingValveOutputHandler. Especially for the
implementation in StreamTwoInputSelectableProcessor, it is involved in the
check logic for different input index which would be a blocker for the
following unification of StreamTaskInput/Output.
We could implement a unified ForwardingValveOutputHandler and extract the check
logic for different inputs into the upper StreamTwoInputSelectableProcessor
layer.
Note: StreamTwoInputProcessor would be removed finally, so we keep it as
current way.
was:
Currently StreamOneInputProcessor and StreamTwoInputSelectableProcessor have
separate implementations of ForwardingValveOutputHandler. Especially for the
implementation in StreamTwoInputSelectableProcessor, it couples the internal
input index logic which would be a blocker for the following unification of
StreamTaskInput/Output.
We could realize a unified ForwardingValveOutputHandler for both
StreamOneInput/ TwoInputSelectableProcessor, and it does not consider different
inputs to always consume StreamStatus. Then we refactor the implementation of
StreamStatusMaintainer for judging the status of different inputs internally
before really emitting the StreamStatus.
> Implement a unified ForwardingValveOutputHandler for
> StreamOne/TwoInputSelectableProcessor
> ------------------------------------------------------------------------------------------
>
> Key: FLINK-13762
> URL: https://issues.apache.org/jira/browse/FLINK-13762
> Project: Flink
> Issue Type: Sub-task
> Components: Runtime / Task
> Reporter: zhijiang
> Assignee: zhijiang
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently StreamOneInputProcessor and StreamTwoInputSelectableProcessor have
> separate implementations of ForwardingValveOutputHandler. Especially for the
> implementation in StreamTwoInputSelectableProcessor, it is involved in the
> check logic for different input index which would be a blocker for the
> following unification of StreamTaskInput/Output.
> We could implement a unified ForwardingValveOutputHandler and extract the
> check logic for different inputs into the upper
> StreamTwoInputSelectableProcessor layer.
> Note: StreamTwoInputProcessor would be removed finally, so we keep it as
> current way.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
