azagrebin commented on a change in pull request #9512:
[FLINK-13819][coordination] Introduce State for RpcEndpoint
URL: https://github.com/apache/flink/pull/9512#discussion_r316725950
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/RpcEndpoint.java
##########
@@ -79,6 +79,9 @@
* of the executing rpc server. */
private final MainThreadExecutor mainThreadExecutor;
+ /** Rpc endpoint's state. */
+ private State state;
Review comment:
As the getter says the state is supposed to be read/written only in the main
thread of the endpoint then there is no need for the synchronisation and I want
to avoid confusion but adding volatile.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
