azagrebin commented on a change in pull request #9512: 
[FLINK-13819][coordination] Introduce State for RpcEndpoint
URL: https://github.com/apache/flink/pull/9512#discussion_r316729861
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/RpcEndpoint.java
 ##########
 @@ -323,6 +355,15 @@ public void validateRunsInMainThread() {
                assert 
MainThreadValidatorUtil.isRunningInExpectedThread(currentMainThread.get());
        }
 
+       /**
+        * Rpc endpoint's state.
+        */
+       public enum State {
 
 Review comment:
   The states basically reflect the lifecycle of the RPC Endpoint (as written 
in JIRA) and what one can do with it by calling the available methods: 
start/stop/close and getting callbacks: onStart and onStop.
   Then the concrete endpoints can easier judge about the state in concrete API 
calls (also in JIRA).
   I can add a jdoc comment about when the transitions happen.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to