[
https://issues.apache.org/jira/browse/FLINK-13832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914985#comment-16914985
]
Kostas Kloudas commented on FLINK-13832:
----------------------------------------
Hi [~gyfora]! Thanks for the contribution.
The changes (from a first look) look good, but the problem is that this PR
changes a class annotated as public evolving. This is not, strictly speaking, a
public API, but such a change will break user code.
This means that before merging such a change, there should be a discussion, a
FLIP and a voting thread. I know that for such a minute change this is too much
work, but in the long-run, such a process will let the project grow in a
transparent way.
> DefaultRollingPolicy create() method should be renamed to builder()
> -------------------------------------------------------------------
>
> Key: FLINK-13832
> URL: https://issues.apache.org/jira/browse/FLINK-13832
> Project: Flink
> Issue Type: Improvement
> Components: Connectors / FileSystem
> Affects Versions: 1.9.0
> Reporter: Gyula Fora
> Assignee: Gyula Fora
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The DefaultRollingPolicy.create() method returns an instance of
> PolicyBuilder not a DefaultRollingPolicy. Therefore we should add a new
> method named .builder() and deprecate "create".
> Right now if we want to create a new instance with the default settings we
> have to call:
> DefaultRollingPolicy.create().build()
> This nicely illustrates the problem with the naming of this method.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
