[
https://issues.apache.org/jira/browse/FLINK-13832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915051#comment-16915051
]
Kostas Kloudas commented on FLINK-13832:
----------------------------------------
The PR you have opened has the method {{DefaultRollingPolicy.create()}} renamed
to {{DefaultRollingPolicy.builder()}}, right? Or am I missing something? I am
referring to this change as breaking.
> DefaultRollingPolicy create() method should be renamed to builder()
> -------------------------------------------------------------------
>
> Key: FLINK-13832
> URL: https://issues.apache.org/jira/browse/FLINK-13832
> Project: Flink
> Issue Type: Improvement
> Components: Connectors / FileSystem
> Affects Versions: 1.9.0
> Reporter: Gyula Fora
> Assignee: Gyula Fora
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The DefaultRollingPolicy.create() method returns an instance of
> PolicyBuilder not a DefaultRollingPolicy. Therefore we should add a new
> method named .builder() and deprecate "create".
> Right now if we want to create a new instance with the default settings we
> have to call:
> DefaultRollingPolicy.create().build()
> This nicely illustrates the problem with the naming of this method.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
