gyfora commented on a change in pull request #9533: [FLINK-13850] [Connectors /
FileSystem] Refactor part file configuration into a single method
URL: https://github.com/apache/flink/pull/9533#discussion_r317583723
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/PartFileConfig.java
##########
@@ -34,19 +34,34 @@
private final String partSuffix;
+ /**
+ * Initiates the {@code PartFileConfig} with default values [{@value
DEFAULT_PART_PREFIX}, {@value DEFAULT_PART_SUFFIX}].
+ */
PartFileConfig() {
Review comment:
The PartFileConfig class itself, and all constructors and methods should be
public so people can create it.
I think we should also make the fields non-final and add setters (or a
builder).
Ideally the user will create a new PartFileConfig with the defaults and
override some parameters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
